macOS: fix FFMPEG 7.1 host compiler lacks C11 support issue on macOS #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFMPEG 7.1 introduces a new issue where "Host C11" testing fails due due to configure not being able to find system support libraries. A similar/related issue was fixed previously where --extra-cflags and --extra-ldflags needed to be set to point configure to the system includes and libraries. To resolve this, the host-cflags and host-ldflags options must be set to the same values as --extra-cflags and --extra-ldflags. The --host-cppflags and --extra-cxxflags were added for completeness. An additional update included searching the compiler for either Xcode or CommandLineTools as the user may have selected one or the other with xcode-select -s. In either case, the correct path to the respective SDK's is stored in OSX_SDK_ROOT, so use that path vs. the previous hard code.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFMPEG 7.1 introduces a new issue where "Host C11" testing fails due
due to configure not being able to find system support libraries.
A similar/related issue was fixed previously where --extra-cflags
and --extra-ldflags needed to be set to point configure to the
system includes and libraries.
To resolve this, the host-cflags and host-ldflags options must be
set to the same values as --extra-cflags and --extra-ldflags. The
--host-cppflags and --extra-cxxflags were added for completeness.
An additional update included searching the compiler for either
Xcode or CommandLineTools as the user may have selected one or
the other with xcode-select -s. In either case, the correct path
to the respective SDK's is stored in OSX_SDK_ROOT, so use that path
vs. the previous hard code.
Thank you for contributing to MythTV!
Please review the checklist below to ensure that your contribution
to MythTV is ready for review by our developers.
It is helpful to regularly rebase your pull request to ensure changes
apply cleanly to the current MythTV development branch.
Checklist