Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks the addition of MythTV version 0.28-pre to MAF #179

Open
billmeek opened this issue Sep 16, 2013 · 10 comments
Open

Tracks the addition of MythTV version 0.28-pre to MAF #179

billmeek opened this issue Sep 16, 2013 · 10 comments
Assignees
Milestone

Comments

@billmeek
Copy link
Contributor

Requires: MythTV-Clients/MythTV-Service-API/issues/16 to be
resolved 1st.

At this point, MAF can use v027 code for v028.

@ghost ghost assigned dmfrey Sep 16, 2013
@billmeek
Copy link
Contributor Author

Note that this can be closed as soon as 0.28 follows the same path as
0.27 does now. The additional features don't exist in MAF and can't be
considered a bug.

@dmfrey
Copy link
Contributor

dmfrey commented Oct 4, 2013

move to v1.30.0?

@billmeek
Copy link
Contributor Author

billmeek commented Oct 4, 2013

Moving to 130.0 is fine. But now we can no longer say MAF
works with 0.25+. Rather 0.25-0.27. And, that's OK for most
users, especially since 0.28 doesn't exist (only the tag 0.28-pre.)

So, it's moved to 1.30.0 and I change the label to enhancement.

This remains a sticky issue for me as I'm now 281 commits behind
on my production host and my test host can't be used with MAF.

@billmeek
Copy link
Contributor Author

billmeek commented Oct 5, 2013

Workaround, as long as no 0.27 protocol is changed:

diff --git a/src/main/java/org/mythtv/services/api/connect/MythAccessFactory.java b/src/main/java/org/mythtv/services/api/connect/MythAccessFactory.java
index 478d483..f41277f 100644
--- a/src/main/java/org/mythtv/services/api/connect/MythAccessFactory.java
+++ b/src/main/java/org/mythtv/services/api/connect/MythAccessFactory.java
@@ -111,6 +111,8 @@ public class MythAccessFactory {
                             return ApiVersion.v026;
                         else if(version.startsWith("0.27"))
                             return ApiVersion.v027;
+                        else if(version.startsWith("0.28"))
+                            return ApiVersion.v027;
                     }
                 }

@dmfrey
Copy link
Contributor

dmfrey commented Oct 5, 2013

Sounds good. We should through a todo to fix it when the services api adds
v0.28.

@billmeek
Copy link
Contributor Author

billmeek commented Oct 5, 2013

I wasn't going to commit it. It's would be dangerous for 0.28-pre
users if a MythTV Services API commit changed existing protocol.

@dmfrey
Copy link
Contributor

dmfrey commented Oct 5, 2013

Do we OK now if there have been any api changes since the release of v0.27?

@billmeek
Copy link
Contributor Author

billmeek commented Oct 5, 2013

No changes, just 11 additions. See the very
bottom of this link.

http://code.mythtv.org/cgit/mythtv/commit/?id=de990998c84b5d0d064a5f9b052249bd9e41d372

@dmfrey
Copy link
Contributor

dmfrey commented Oct 5, 2013

We should be OK for the time being.

@billmeek
Copy link
Contributor Author

Pushed v1.30 to GitHub. 10/28/2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants