[fastx types] stored module bytes in Object instead of CompiledModule #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to derive Serialize and Deserialize directly.
gdanezis
approved these changes
Dec 24, 2021
| /// A published Move module | ||
| Module(CompiledModule), | ||
| /// Raw bytes that deserialize to a published Move module | ||
| Module(Vec<u8>), |
There was a problem hiding this comment.
I think that eventually we should use an immutable bytes type here with an efficient clone, since we never really mutate these bytes -- we only construct new objects. Similarly we should use serde-bytes for ser/deser. Down the line ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow us to derive
SerializeandDeserializeforObject.