[CI] Add basic benchmarking job #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
reviewed
Dec 15, 2021
| body="${body//$'\r'/'%0D'}" | ||
| echo ::set-output name=body::$body | ||
| - name: Create commit comment | ||
| uses: peter-evans/commit-comment@v1 |
There was a problem hiding this comment.
Comment explaining what this peter-evans magic is could be useful.
There was a problem hiding this comment.
This is just a github action creating a comment on the commit:
https://github.com/peter-evans/commit-comment
sblackshear
approved these changes
Dec 15, 2021
gdanezis
reviewed
Dec 15, 2021
| - name: run benchmark | ||
| run: | | ||
| set -o pipefail | ||
| cargo run --release --bin bench 2>&1 | huniq | tee -a artifacts/bench_results.txt |
There was a problem hiding this comment.
Is 'cargo run --release --bin bench' working for you? Because it seems that there are some missing lock issues. Maybe we do not init the DB correctly.
mwtian
pushed a commit
that referenced
this pull request
Sep 12, 2022
[feature]: introduce a new component, the BlockWaiter. BlockWaiter will basically act as an aggregator and fetch the batches that correspond to a header by providing a certificate id.
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
[feature]: introduce a new component, the BlockWaiter. BlockWaiter will basically act as an aggregator and fetch the batches that correspond to a header by providing a certificate id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
A CI job that runs
cargo run --release --bin benchon each new commit and posts the results as a commit comment.Why
See #54 : our current benchmarking capacities are bit-rotting a bit. Let's stop this.
Next steps
Tests
Please find a successful run of the bench on my fork here:
https://github.com/huitseeker/fastnft/actions/runs/1580740243
And a subsequent comment at the bottom of this commit:
https://github.com/huitseeker/fastnft/commit/ffad063381f8ec4be9ca40c76448d3f8ec106ae5