Cleanup old benchmark code #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sadhansood could you share the command invocation to use to run the new benchamrking tool locally? |
bmwill
approved these changes
Sep 12, 2022
|
Thanks for the cleanup @sadhansood |
sadhansood
force-pushed
the
sadhan/remove_old_benchmark
branch
from
e3bf260 to
2553f20
Compare
sadhansood
force-pushed
the
sadhan/remove_old_benchmark
branch
from
2553f20 to
722ebb7
Compare
sadhansood
added a commit
that referenced
this pull request
Sep 13, 2022
* Fix metric collection for network client in stress test * Cleanup old benchmark code
sadhansood
added a commit
that referenced
this pull request
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current load gen supporting both local and remote mode and running in private testnets, we don't need to keep around the old load gen and benchmark code anymore as that only causes confusion (at least for new users).