Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy #4570

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Fix clippy #4570

merged 1 commit into from
Sep 12, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Sep 12, 2022

No description provided.

Copy link
Contributor

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, the same job at https://github.com/MystenLabs/sui/runs/8296329081?check_suite_focus=true is pointing out the following unneeded dependencies:

unused dependencies:
`sui v0.9.0 (/home/runner/work/sui/sui/crates/sui)`
└─── dependencies
     └─── "sui-simulator"
`sui-config v0.0.0 (/home/runner/work/sui/sui/crates/sui-config)`
└─── dependencies
     └─── "sui-simulator"
`sui-macros v0.7.0 (/home/runner/work/sui/sui/crates/sui-macros)`
└─── dependencies
     └─── "darling"
`sui-swarm v0.0.0 (/home/runner/work/sui/sui/crates/sui-swarm)`
└─── dependencies
     └─── "sui-simulator"
Note: These dependencies might be used by other targets.
      To find dependencies that are not used by any target, enable `--all-targets`.
Note: They might be false-positive.
      For example, `cargo-udeps` cannot detect usage of crates that are only used in doc-tests.
      To ignore some dependencies, write `package.metadata.cargo-udeps.ignore` in Cargo.toml.
Error: Process completed with exit code 1.

For your consideration.

@lxfind
Copy link
Contributor Author

lxfind commented Sep 12, 2022

@mystenmark Can you take a look at the udeps failure in the nightly build? It seems that I cannot remove those deps otherwise simtest would fail.

@lxfind lxfind merged commit 2fa91f3 into main Sep 12, 2022
@lxfind lxfind deleted the fix-clippy branch September 12, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants