Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More info in telemetry event #4531

Merged
merged 1 commit into from
Sep 13, 2022
Merged

More info in telemetry event #4531

merged 1 commit into from
Sep 13, 2022

Conversation

gegaowp
Copy link
Contributor

@gegaowp gegaowp commented Sep 8, 2022 •
edited
Loading

This PR adds more info to the node telemetry events.
Test with local nodes:

  • timestamp (secs from epoch) to compute active nodes over past X days
    Screen Shot 2022-09-08 at 4 17 41 PM
  • git revision
    Screen Shot 2022-09-08 at 4 17 23 PM
  • fullnode or validator tag
    Screen Shot 2022-09-08 at 4 17 31 PM

@gegaowp gegaowp marked this pull request as ready for review September 8, 2022 20:26
gegaowp
gegaowp commented Sep 8, 2022
View reviewed changes
crates/sui-node/src/main.rs Outdated Show resolved Hide resolved
@gegaowp gegaowp force-pushed the telemetry-more-info branch from f861543 to 923dc86 Compare September 8, 2022 20:34
@gegaowp gegaowp force-pushed the telemetry-more-info branch from 923dc86 to 769e363 Compare September 12, 2022 14:13
@gegaowp gegaowp merged commit 87e126e into MystenLabs:main Sep 13, 2022
@gegaowp gegaowp deleted the telemetry-more-info branch September 13, 2022 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longbowlu longbowlu longbowlu approved these changes

@666lcz 666lcz Awaiting requested review from 666lcz

@lxfind lxfind Awaiting requested review from lxfind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gegaowp @longbowlu