-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explorer] Prevents collision when owned object has more text #4529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Andrew47 in addition to adding details for rules (max line of text to show) i have also added details for small screen size breakpoints in this Figma here,
https://www.figma.com/file/kSD0qXCIDZA4KQVNepA5hR/02-Explorer?node-id=204%3A48379
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better @Andrew47 . May I request a few more tweaks to improve the layout,
- padding between columns -> 40px
- empty placeholder asset when we don’t have an image -> use the assets with the image icon in Figma
- padding between image and text should be 15 (looks a lot more in the screenshot attached to task)
- space between items on mobile - let’s update it to 10px (new request)
Totally lost track of plot. this task is not meant for the updates in my last comment. |
The Problem
The problem is that when the owned objects have long pieces of summary text, this text collides. This can be seen here: https://explorer.devnet.sui.io/addresses/0x9b598c9c5f28c94a660d3cbc047f67a510a60e7a
The Solution in Action
With longer text
With shorter text