[refactor] move fastx core types and authority into separate crates #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
requested review from
huitseeker,
lxfind,
patrickkuo and
gdanezis
sblackshear
force-pushed
the
separate_deps
branch
from
9a9f726
to
758b826
Compare
lxfind
reviewed
Dec 8, 2021
fastx_types/src/base_types.rs
Outdated
| @@ -59,7 +58,6 @@ pub fn address_to_object_id_hack(address: FastPayAddress) -> ObjectID { | |||
| .expect("An address is always long enough to extract 16 bytes") | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
Why removing all of the cfg test annotations?
There was a problem hiding this comment.
This function is now in a different crate from some of its callers, but code gated by cfg(test) is not gated outside of its declaring crate: rust-lang/cargo#8379
lxfind
approved these changes
Dec 8, 2021
Separate out the fastx base types (used by clients, the adapter, authority, ...) and the authority code. A future PR connecting the `fastx-programmability` and `fastpay-core` crates leads to cyclic dependencies without this refactor.
sblackshear
force-pushed
the
separate_deps
branch
from
758b826
to
fb7e5b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out the fastx base types (used by clients, the adapter, authority, ...) and the authority code into separate Rust crates. A future PR connecting the
fastx-programmabilityandfastpay-corecrates leads to a cyclic dependency without this refactor.