[sui-framework] Refactor id module to object
#3241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sui-explorer
Type: Documentation
sblackshear
approved these changes
Jul 15, 2022
- `sui::id` is now `sui::object` - `VersionedID` renamed to `Info` - Various ID and Info helpers have been renamed - Moved object creation from tx_context to object
Clay-Mysten
approved these changes
Jul 18, 2022
There was a problem hiding this comment.
Great work, Todd! Thank you so much for including docs updates in this change. They LGTM assuming this linked file goes live with it (tried to pick through and confirm myself):
https://github.com/MystenLabs/sui/blob/main/crates/sui-framework/sources/object.move
Also, I think we should note this change here:
https://docs.sui.io/learn#see-whats-new
I will do that after you merge this and send the PR for your review. Thanks again!
| struct type defined in the | ||
| [ID module](https://github.com/MystenLabs/sui/blob/main/crates/sui-framework/sources/id.move). The | ||
| [object module](https://github.com/MystenLabs/sui/blob/main/crates/sui-framework/sources/object.move). The |
There was a problem hiding this comment.
Is this file being renamed?:
object module
It doesn't exist now.
There was a problem hiding this comment.
Correct, it's a renamed module after this PR lands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sui::idis nowsui::objectVersionedIDrenamed toInfoVarious ID and Info helpers have been renamed
Moved object creation from tx_context to object
A lot of changes to docs, but I will be doing a more detailed pass in a future PR