[Move] Update build command in doc and fix a typo in a move file #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, that is a mistake in the instructions--should be |
|
Speaking of which: I realized we actually don't test that the Move build artifacts are up-to-date yet (filed #26 for this). |
sblackshear
requested changes
Dec 3, 2021
There was a problem hiding this comment.
I think we should probably leave the code in examples, but switch the README instructions to say move package -d build. The scripts dir is supposed to be for transaction scripts that contain a single function (no modules), but I guess the package tooling does not check this.
lxfind
changed the title
sblackshear
approved these changes
Dec 3, 2021
brson
pushed a commit
to brson/sui
that referenced
this pull request
Apr 30, 2024
…bs#24) More tests will be added when I wire these to the test case runners.
brson
pushed a commit
to brson/sui
that referenced
this pull request
Apr 30, 2024
…own gas budget parameters (MystenLabs#26) Follow up from MystenLabs#24 Fixes: MystenLabs#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move package buildcommand will look for move files under sources/ and scripts/.Renaming examples to scripts will allow move build to actually build them.