-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coinmarketcap Deepbook Endpoints #20453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
November 27, 2024 20:15 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 22:01 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 22:08 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 22:11 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 22:15 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 22:23 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 22:24 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 23:04 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 2, 2024 23:06 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 3, 2024 17:58 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 3, 2024 18:44 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 3, 2024 18:48 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 3, 2024 19:03 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 3, 2024 19:18 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 3, 2024 19:24 — with
GitHub Actions
Inactive
leecchh
force-pushed
the
tlee/cmc-endpoints
branch
from
December 4, 2024 15:54
91c7416
to
a31b617
Compare
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 4, 2024 15:54 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 4, 2024 16:06 — with
GitHub Actions
Inactive
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 4, 2024 16:26 — with
GitHub Actions
Inactive
0xaslan
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, would be nice if we can get rid of all unwrap()
leecchh
temporarily deployed
to
sui-typescript-aws-kms-test-env
December 4, 2024 17:21 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified Endpoint 1:
/get_historical_volume/:pool_id -> /historical_volume/pool_name
Response will display pool as pool_name
Example call:
/historical_volume/SUI_USDC,DEEP_USDC?start_time=1733152516&end_time=1733238917
Example response:
{"DEEP_USDC":24033500000000,"SUI_USDC":2647584300000000}
New Endpoint 1: /all_historical_volume
Retrieves the pools stored in db and return volume for all pools within time range
Example Call:
/all_historical_volume?start_time=1733152516&end_time=1733238917
Example Response:
{"DEEP_USDC":23658150000000,"DEEP_SUI":5311220000000,"TYPUS_SUI":662314300000000,"SUI_USDC":3365051200000000,"WUSDC_USDC":7960304900000,"NS_USDC":783869300000,"NS_SUI":379958200000}
New Endpoint 2: /orderbook/:pool_name
More information: https://docs.google.com/document/d/1S4urpzUnO2t7DmS_1dc4EL4tgnnbTObPYXvDeBnukCg/edit?tab=t.0#bookmark=kix.ojdax1m5sg58
Required path:
pool_name
: "LTC_BTC"Optional params:
level
(1 or 2): Level 1 – Only the best bid and ask. Level 2 – Arranged by best bids and asks.depth
: Not defined or 0 = full order book Depth = 100 means 50 for each bid/ask side. Cannot be 1.All bids and asks returned are sorted by best to worst
Example call:
/orderbook/SUI_USDC?depth=4
Example output:
{"timestamp":"1733252111939","bids":[["3.796","958.5"],["3.795","5000"]],"asks":[["3.799","1000"],["3.801","7238"]]}
Test plan
How did you test the new or updated feature?
Tested locally
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
/all_historical_volume
and/orderbook/:pool_name
endpoints to the DeepBook Indexer API./all_historical_volume
retrieves the pools stored in the database and returns volume for all pools within a time range./orderbook/:pool_name
retrieves the level and depth of the requested order book pool. The PR also updates the/get_historical_volume/:pool_id
endpoint to read/historical_volume/pool_name
.