Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build to .gitignore in sui move new #20395

Merged
merged 20 commits into from
Nov 26, 2024
Merged

Conversation

mdgeorge4153
Copy link
Contributor

@mdgeorge4153 mdgeorge4153 commented Nov 22, 2024

Description

  • Adds build/* to .gitignore when invoking sui move new (extending it if it already exists)
  • Splits out move new implementation into smaller functions

Test plan

I added to the move new unit tests; checking the case where the .gitignore already exists, and extended the existing tests to check that it was added.

Note that I didn't add tests to sui move new, only move new.


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI: When issuing sui move new command, a .gitignore file will be added to the project's folder.
  • Rust SDK:
  • REST API:

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 5:56pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 5:56pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 5:56pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 5:56pm

@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env November 22, 2024 19:36 — with GitHub Actions Inactive
@stefan-mysten
Copy link
Contributor

stefan-mysten commented Nov 22, 2024

Thanks @mdgeorge4153 for starting the work on this. Left a few comments and looking forward to see this merged!

Regarding the Release notes part from above, when a box is selected, we need to enter a description with the change. For example, in this case it could be something like this:

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required._

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] omitted the rest of options
- [x] CLI: When issuing `sui move new` command, a `.gitignore` file will be added to the project's folder.

@amnn amnn requested review from a team November 25, 2024 15:27
Copy link
Member

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great modulo some smaller comments, thanks for the surrounding clean-ups @mdgeorge4153 !

external-crates/move/crates/move-cli/src/base/new.rs Outdated Show resolved Hide resolved
external-crates/move/crates/move-cli/src/base/new.rs Outdated Show resolved Hide resolved
external-crates/move/crates/move-cli/src/base/new.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@stefan-mysten stefan-mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdgeorge4153 mdgeorge4153 temporarily deployed to sui-typescript-aws-kms-test-env November 26, 2024 17:55 — with GitHub Actions Inactive
@mdgeorge4153 mdgeorge4153 merged commit edf7a29 into main Nov 26, 2024
51 of 52 checks passed
@mdgeorge4153 mdgeorge4153 deleted the mdgeorge/move-new-refactor branch November 26, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants