-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build
to .gitignore
in sui move new
#20395
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Thanks @mdgeorge4153 for starting the work on this. Left a few comments and looking forward to see this merged! Regarding the Release notes part from above, when a box is selected, we need to enter a description with the change. For example, in this case it could be something like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great modulo some smaller comments, thanks for the surrounding clean-ups @mdgeorge4153 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
build/*
to.gitignore
when invokingsui move new
(extending it if it already exists)move new
implementation into smaller functionsTest plan
I added to the
move new
unit tests; checking the case where the.gitignore
already exists, and extended the existing tests to check that it was added.Note that I didn't add tests to
sui move new
, onlymove new
.Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
sui move new
command, a.gitignore
file will be added to the project's folder.