Add bcs field to Checkpoint

[stefan-mysten]

Description

This PR adds the bcs for Checkpoint to enable GraphQL Client to correctly handle CheckpointSummary data.

Test plan

Added the field to two existing tests and updated the snapshots. A bit uncertain why some things have changed, so would need some help to figure out if it's correct or not. @wlmyng

---

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

• Protocol:
• Nodes (Validators and Full nodes):
• Indexer:
• JSON-RPC:
• GraphQL: Checkpoint now has a bcs field that represents the Base64 encoded BCS serialization of the CheckpointSummary data.
• CLI:
• Rust SDK:
• REST API:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sui-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 22, 2024 6:28pm

3 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
multisig-toolkit	⬜️ Ignored (Inspect)	Visit Preview		Nov 22, 2024 6:28pm
sui-kiosk	⬜️ Ignored (Inspect)	Visit Preview		Nov 22, 2024 6:28pm
sui-typescript-docs	⬜️ Ignored (Inspect)	Visit Preview		Nov 22, 2024 6:28pm

[amnn]

This implementation is changing things it doesn't need to, which is why I think you're getting in trouble with the pagination of regular checkpoints, it would be better to implement it as follows:

• Implement a DataLoader for raw checkpoint information (keyed by sequence number).
• Implement the bcs field as a load_one for that data loader.
• Delete everything else because you don't need it.

[stefan-mysten]

This implementation is changing things it doesn't need to, which is why I think you're getting in trouble with the pagination of regular checkpoints, it would be better to implement it as follows:

* Implement a DataLoader for raw checkpoint information (keyed by sequence number).

* Implement the `bcs` field as a `load_one` for that data loader.

* Delete everything else because you don't need it.

That makes total sense, thanks so much. @wlmyng was hinting at that yesterday but I did not get it at the time. Much nicer to write!

[amnn]

Implementation looks great modulo some nits! I did have a question about whether it implies we should be returning the CertifiedCheckpointSummary in the BCS field, rather than just the CheckpointSummary. Maybe @lxfind and @bmwill have thoughts on that as well.

[amnn]

Accepting modulo the nits! Thanks @stefan-mysten

[bmwill]

lgtm as well, module Ashok's comments

[stefan-mysten]

Addressed all the nits, thanks @amnn and @bmwill!