-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive the Move prover #20339
Draft
cos
wants to merge
126
commits into
MystenLabs:main
Choose a base branch
from
asymptotic-code:revive_prover
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Revive the Move prover #20339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6fd3d2f.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds back the Sui Move prover with significant changes and enhancements.
The most important change is that the prover no longer uses special syntax. The specifications are now given via special functions, macros, naming conventions and annotations. This has several advantages, including:
requires
can be extracted outThe prover now supports:
AMM example: kunalabs-io/sui-smart-contracts#9
Features/Changes
std::integer
andstd::real
std::integer
module for arbitrary-precision integer arithmeticstd::real
module for real number operationsprover
modulerequires
- specifies preconditions (renamed fromassume
for clarity)ensures
- specifies postconditionsasserts
- Replacesabort-if
with its complement, which is more in line with existingassert
statements (can simply copy-paste in many cases)invariant!
macro for loop invariantsold!
macro for referencing pre-state valuesdeclare_global
/declare_global_mut
prover native commandsglobal
prover native for state manipulationf_spec
for functionf
requires
/ensures
/asserts
is particularly interestinginvariant!
macroS_inv
for structS
#spec_only
annotation_spec
variablesTest plan
Release notes
The changes should not affect any of the existing functionality. We still recommend extensive testing as we made some changes to the compiler to support
spec_only
and related.