Force WritebackCache on #20275
Merged
Force WritebackCache on #20275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
changed the title
aschran
reviewed
Nov 15, 2024
| } else { | ||
| ExecutionCacheConfigType::WritebackCache | ||
| if std::env::var(DISABLE_WRITEBACK_CACHE_ENV_VAR).is_ok() { | ||
| error!("DISABLE_WRITEBACK_CACHE is no longer respected. WritebackCache is the default."); |
There was a problem hiding this comment.
i don't think so? i don't think this will affect anyone anyway.
|
|
||
| if matches!( | ||
| epoch_start_config.execution_cache_type(), | ||
| ExecutionCacheConfigType::WritebackCache |
There was a problem hiding this comment.
would it be safer (future proof) to make this an exhuastive match?
There was a problem hiding this comment.
there definitely won't be any new cache types - as soon as I can i will strip all of this conditional stuff out.
aschran
approved these changes
Nov 15, 2024
…des currently using it do not break)
mystenmark
force-pushed
the
mlogan-remove-proxy-cache
branch
from
6d6dc2a
to
59b8d2f
Compare
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
mystenmark
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PassthroughCache as an option, but leave the code in place so that nodes currently using it do not break