Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] dry run should use dev inspect executor #20109

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[core] dry run should use dev inspect executor #20109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fdd88bd
[core] dry run should use dev inspect executor
jordanjennings-mysten Oct 31, 2024
c601bb3
pull skip_all_checks into its own variable
jordanjennings-mysten Oct 31, 2024
85afc9d
add test to check object ownership on dry run enforced
jordanjennings-mysten Nov 14, 2024
ed9b3e3
no arbitrary function and publish dry run tests
jordanjennings-mysten Nov 14, 2024
3f0e2db
fix comments
jordanjennings-mysten Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions crates/sui-core/src/authority.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1834,25 +1834,26 @@ impl AuthorityState {
.expect("Creating an executor should not fail here");

let expensive_checks = false;
let (inner_temp_store, _, effects, _execution_error) = executor
.execute_transaction_to_effects(
self.get_backing_store().as_ref(),
protocol_config,
self.metrics.limits_metrics.clone(),
expensive_checks,
self.config.certificate_deny_config.certificate_deny_set(),
&epoch_store.epoch_start_config().epoch_data().epoch_id(),
epoch_store
.epoch_start_config()
.epoch_data()
.epoch_start_timestamp(),
checked_input_objects,
gas_object_refs,
gas_status,
kind,
signer,
transaction_digest,
);
let skip_all_checks = false;
let (inner_temp_store, _, effects, _execution_error) = executor.dev_inspect_transaction(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you speak a bit more to the motivation here? This is potentially a really big regression for folks, since it will increase the space for transactions that will pass "dry run" but then fail at execution.
For example, someone could do something they feel is harmless, like construct some user defined struct or enum from CallArg::Pure. Dev inspect will gladly let you do this, but dry run (and in turn normal execution), will give you an error. There is a very long list of this sort of differing behavior.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to refresh before making this comment and now see all the other comments above. Reading.

self.get_backing_store().as_ref(),
protocol_config,
self.metrics.limits_metrics.clone(),
expensive_checks,
self.config.certificate_deny_config.certificate_deny_set(),
&epoch_store.epoch_start_config().epoch_data().epoch_id(),
epoch_store
.epoch_start_config()
.epoch_data()
.epoch_start_timestamp(),
checked_input_objects,
gas_object_refs,
gas_status,
kind,
signer,
transaction_digest,
skip_all_checks,
);
let tx_digest = *effects.transaction_digest();

let module_cache =
Expand Down
Loading
Loading