graphql: expose MovePackage as BCS (packageBcs) #19818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description
Spotted that MovePackage queries were still using `objects_history`,
which is not going to work after that table gets pruned to two epochs.
This PR replaces queries to `objects_history` with queries to
`full_objects_history`, with support from `objects_version` and
`packages` to fetch the checkpoint sequence number where necessary.
## Test plan
Existing tests:
```
sui$ cargo nextest run -p sui-graphql-e2e-tests
```
And ran the following queries on the mainnet DB:
```graphql
query AllPackages($after: String) {
packages(first: 5 after: $after) {
pageInfo {
hasNextPage
endCursor
startCursor
}
nodes {
address
version
}
}
}
query AllPackagesBack($before: String) {
packages(last: 5 before: $before) {
pageInfo {
hasNextPage
endCursor
startCursor
}
nodes {
address
version
}
}
}
query SystemPackages($after: String) {
packageVersions(address: "0x2" first: 5 after: $after) {
pageInfo {
hasNextPage
endCursor
startCursor
}
nodes {
address
version
}
}
}
query SystemPackagesBack($before: String) {
packageVersions(address: "0x2" last: 5 before: $before) {
pageInfo {
hasNextPage
endCursor
}
nodes {
address
version
}
}
}
query UserPackage($after: String) {
packageVersions(
address: "0xbc3df36be17f27ac98e3c839b2589db8475fa07b20657b08e8891e3aaf5ee5f9"
first: 5
after: $after
) {
pageInfo {
hasNextPage
endCursor
startCursor
}
nodes {
address
version
}
}
}
```
## Description Add a new field -- `MovePackage.packageBcs` -- that exposes the BCS representation of the MovePackage. This complements `bcs` (which is the BCS representation of its `Object` form), and `moduleBcs` (which is the BCS representation of its `Vec<CompiledModule>`s). ## Test plan New E2E test: ``` sui$ cargo nextest run -p sui-graphql-e2e-tests -- packages/bcs.move ```
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
stefan-mysten
approved these changes
Oct 11, 2024
|
Thanks @amnn !!! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new field --
MovePackage.packageBcs-- that exposes the BCS representation of the MovePackage. This complementsbcs(which is the BCS representation of itsObjectform), andmoduleBcs(which is the BCS representation of itsVec<CompiledModule>s).Test plan
New E2E test:
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
MovePackage.packageBcsto expose the BCS representation of theMovePackagestruct (as opposed to the BCS representation of the outerObjectstruct).