graphql: Remove TransactionBlockFilter.signAddress and AddressTransactionBlockRelationship.SIGN #19804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
This was referenced Oct 10, 2024
Merged
…tionBlockRelationship.SIGN ## Description Formally remove - `TransactionBlockFilter.signAddress` and - `AddressTransactionBlockRelationship.SIGN` which were deprecated two releases ago. They have been replaced by - `TransactionBlockFilter.sentAddress` and - `AddressTransactionBlockRelationship.SENT` which offer the same features under clearer names. ## Test plan ``` sui$ cargo nextest run -p sui-graphql-rpc sui$ cargo nextest run -p sui-graphql-rpc --features staging sui$ cargo nextest run -p sui-graphql-e2e-tests ```
amnn
force-pushed
the
amnn/gql-rm-sign-addr
branch
from
6c6d653 to
4fb458d
Compare
8 tasks
github-actions
bot
added
the
Type: Documentation
bmwill
approved these changes
Oct 11, 2024
amnn
added a commit
that referenced
this pull request
Oct 11, 2024
…tionBlockRelation.RECV (#19805) ## Description These fields were flagged for deprecation in 1.34 and have been replaced in 1.35 by - `TransactionBlockFilter.affectedAddress` and - `AddressTransactionBlockRelation.AFFECTED` Which offer a similar (but not exactly the same) semantics, but without confusion around the sender address which was often also an implicit recipient of a transaction. ## Test plan ``` sui$ cargo nextest run -p sui-graphql-rpc sui$ cargo nextest run -p sui-graphql-rpc --features staging sui$ cargo nextest run -p sui-graphql-e2e-tests ``` ## Stack - #19708 - #19802 - #19803 - #19804 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] Indexer: - [ ] JSON-RPC: - [x] GraphQL: `TransactionBlockFilter.recvAddress` and `AddressTransactionBlockRelation.RECV` have been replace by `TransactionBlockFilter.affectedAddress` and `AddressTransactionBlockRelation.AFFECTED` which offer similar semantics, but without confusion around the sender address which was also often (but not always) an implicit recipient. Now we don't distinguish between senders and recipients -- we only have senders and "affected" addresses which were touched by the transaction in some way. - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
amnn
added a commit
that referenced
this pull request
Oct 14, 2024
## Description All references to these fields have been removed from readers, so we can stop keeping it up-to-date. Once this change lands, we can also clean these tables from the schema. ## Test plan ``` sui$ cargo nextest run -p sui-indexer ``` ## Stack - #19708 - #19802 - #19803 - #19804 - #19805 --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [x] Indexer: Indexer no longer fills the `tx_sender` and `tx_recipient` tables. - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: - [ ] REST API:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Formally remove
TransactionBlockFilter.signAddressandAddressTransactionBlockRelationship.SIGNwhich were deprecated two releases ago. They have been replaced by
TransactionBlockFilter.sentAddressandAddressTransactionBlockRelationship.SENTwhich offer the same features under clearer names.
Test plan
Stack
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
TransactionBlockFilter.signAddressandAddressTransactionBlockRelationship.SIGNwhich were deprecated two releases ago. They have been replaced byTransactionBlockFilter.sentAddressandAddressTransactionBlockRelationship.SENTwhich offer the same features under clearer names.