graphql: ObjectOwner::Parent exposed as Owner #19785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description Now that we no longer expose wrapped objects, we need a way to expose the addresses of object parents when they are other objects that have been wrapped. ## Test plan Updated tests: ``` sui$ cargo nextest run -p sui-graphql-e2e-tests sui$ cargo nextest run -p sui-graphql-rpc ```
amnn
requested review from
wlmyng,
stefan-mysten,
emmazzz and
suiwombat
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
8 tasks
wlmyng
approved these changes
Oct 10, 2024
gegaowp
approved these changes
Oct 10, 2024
| @@ -147,6 +147,7 @@ pub(crate) fn build_objects_query( | |||
| // Similar to the snapshot query, construct the filtered inner query for the history table. | |||
| let mut history_objs_inner = query!("SELECT * FROM objects_history"); | |||
| history_objs_inner = filter_fn(history_objs_inner); | |||
| history_objs_inner = filter!(history_objs_inner, "object_status = 0"); | |||
There was a problem hiding this comment.
sry that i missed it here and thx for the fix, is there an easy way to generate a sample query here so that I can verify it on psql?
There was a problem hiding this comment.
You didn't miss it in this case -- I've just moved the filter up into a central place, rather than applying at the end to each query, because it was ambiguous whether the object_status query would apply just to the historical candidates, the newer values or both (and we only want it to apply to the historical candidates).
If you run the GraphQL service with debug logs enabled, you can see every query that gets run. I ran the tests as follows for example:
sui$ RUST_LOG="info,sui_graphql_rpc::data::pg=debug" \
cargo nextest run -p sui-graphql-e2e-tests --no-capture \
-- call/dynamic_fields.move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that we no longer expose wrapped objects, we need a way to expose the addresses of object parents when they are other objects that have been wrapped.
Test plan
Updated tests:
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
Parent.parentfrom anObjectto anOwner. Although it's guaranteed to be an object if it exists, it may be wrapped, in which case it will not exist. Exposing it as an Owner allows queries to extract its ID and also fetch other dynamic fields from it even if it is wrapped.