Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suiop] add date to message output #19233

Merged
merged 1 commit into from
Sep 6, 2024
Merged

[suiop] add date to message output #19233

merged 1 commit into from
Sep 6, 2024

Conversation

after-ephemera
Copy link
Member

Description

Add date output to make it clear when an incident was closed.
Add the slack channel url to short output.

Test plan

DEBUG=true cargo run -- i r -i --limit 1
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.54s
     Running `/Users/jkjensen/mysten/sui/target/debug/suiop i r -i --limit 1`
2024-09-05T20:52:01.898863Z  INFO suiop: Debug mode enabled
3511:0d   [FIRING:1] disk used % Infrastructure (/dev/md1 mainnet ext4 ord-mnt-rpcbig-03 localhost:9091 node-exporter /opt/sui mainnet pagerduty/nre rpc active) (https://mystenlabs.pagerduty.com/incidents/Q1OS8GCY2HHNEB)
> Keep this incident for review? Yes
Incidents marked for review: 3511
Here is the message to send in the channel: 
    
Hello everyone and happy Thursday!

We have selected the following incidents for review:
• 3511 09/05/24 [FIRING:1] disk used % Infrastructure (/dev/md1 mainnet ext4 ord-mnt-rpcbig-03 localhost:9091 node-exporter /opt/sui mainnet pagerduty/nre rpc active) 
    
and the following incidents have been excluded from review:


Please comment in the thread to request an adjustment to the list.
    
> Send this message to the #test-notifications channel? Yes

Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

@after-ephemera after-ephemera requested a review from a team September 5, 2024 20:54
Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 8:58pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Sep 5, 2024 8:58pm
sui-kiosk ⬜️ Ignored (Inspect) Sep 5, 2024 8:58pm
sui-typescript-docs ⬜️ Ignored (Inspect) Sep 5, 2024 8:58pm

@after-ephemera after-ephemera merged commit 47ad468 into main Sep 6, 2024
49 checks passed
@after-ephemera after-ephemera deleted the jkj/suiop-inc-date branch September 6, 2024 18:23
suiwombat pushed a commit that referenced this pull request Sep 16, 2024
## Description 

Add date output to make it clear when an incident was closed.
Add the slack channel url to short output.

## Test plan 

```
DEBUG=true cargo run -- i r -i --limit 1
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.54s
     Running `/Users/jkjensen/mysten/sui/target/debug/suiop i r -i --limit 1`
2024-09-05T20:52:01.898863Z  INFO suiop: Debug mode enabled
3511:0d   [FIRING:1] disk used % Infrastructure (/dev/md1 mainnet ext4 ord-mnt-rpcbig-03 localhost:9091 node-exporter /opt/sui mainnet pagerduty/nre rpc active) (https://mystenlabs.pagerduty.com/incidents/Q1OS8GCY2HHNEB)
> Keep this incident for review? Yes
Incidents marked for review: 3511
Here is the message to send in the channel: 
    
Hello everyone and happy Thursday!

We have selected the following incidents for review:
• 3511 09/05/24 [FIRING:1] disk used % Infrastructure (/dev/md1 mainnet ext4 ord-mnt-rpcbig-03 localhost:9091 node-exporter /opt/sui mainnet pagerduty/nre rpc active) 
    
and the following incidents have been excluded from review:


Please comment in the thread to request an adjustment to the list.
    
> Send this message to the #test-notifications channel? Yes
```

---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants