[chore] bump move version #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Take advantage of diem/move#13, which will allow us to build Move packages concurrently without encountering flakiness due to races in the cache. Split a test that caused flakiness before to demonstrate that it works. This will also allow us to move `ObjectBasics` out of the framework and into a test package, but I don't want to do that here because there are a few in-flight PR's that touch this module.
sblackshear
force-pushed
the
bump_move
branch
from
bd8ffe8 to
c78d584
Compare
|
This is awesome, thank you |
mwtian
pushed a commit
that referenced
this pull request
Sep 12, 2022
Our current solution for hashing batches has 3 components: 1. it relies on never deserializing a batch, so that we hash the serialized message, 2. it is not resilient to hash confusion, lenght extension, etc (see #[87]). 3. it is split in two functions that disagree with each other (see #[188]). This stopgap PR does nothing about 1 & 2, but realigns the `impl Hash for Batch` so that it matches with the rest of the code base, and uses it in processor tests. THe security fixes of the batch hashing will be done in #156. Fixes #188
mwtian
pushed a commit
to mwtian/sui
that referenced
this pull request
Sep 29, 2022
Our current solution for hashing batches has 3 components: 1. it relies on never deserializing a batch, so that we hash the serialized message, 2. it is not resilient to hash confusion, lenght extension, etc (see #[87]). 3. it is split in two functions that disagree with each other (see #[188]). This stopgap PR does nothing about 1 & 2, but realigns the `impl Hash for Batch` so that it matches with the rest of the code base, and uses it in processor tests. THe security fixes of the batch hashing will be done in MystenLabs#156. Fixes MystenLabs#188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take advantage of diem/move#13, which will allow us to build Move packages concurrently without encountering flakiness due to races in the cache. Split a test that caused flakiness before to demonstrate that it works.
This will also allow us to move
ObjectBasicsout of the framework and into a test package, but I don't want to do that here because there are a few in-flight PR's that touch this module.