-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/support move calls from client #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fastpay/src/client.rs
is getting really long! How about creating a split modulefor it?
Is every expect|unwrap
a justifiably program-stopping irrecoverable error?
fastpay/src/client.rs
Outdated
@@ -283,6 +284,44 @@ fn deserialize_response(response: &[u8]) -> Option<ObjectInfoResponse> { | |||
} | |||
} | |||
} | |||
fn find_owner_by_object_cache( | |||
account_config: &mut AccountsConfig, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding tested code suggestions
Co-authored-by: François Garillot <[email protected]>
Co-authored-by: François Garillot <[email protected]>
Co-authored-by: François Garillot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a couple of simplifications, but overall this no longer introduces panics where they can be avoided.
Changes:
Example sh:
Where example
transfer_args.json
:The
package_obj_id
is from framework package https://github.com/MystenLabs/fastnft/blob/main/fastx_types/src/lib.rs#L42TODO: