Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bench failure #148

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Fix bench failure #148

merged 1 commit into from
Jan 10, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Jan 10, 2022

It was reusing the same gas object. We should use a different gas object for each order.

gdanezis
gdanezis approved these changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@gdanezis gdanezis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, many thanks for the fix -- lets land it!

@lxfind lxfind merged commit b15f328 into MystenLabs:main Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdanezis gdanezis gdanezis approved these changes

@huitseeker huitseeker huitseeker approved these changes

@oxade oxade Awaiting requested review from oxade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lxfind @huitseeker @gdanezis