[framework] unify Rust and Move object ID derivation #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblackshear
force-pushed
the
native_object_id
branch
2 times, most recently
from
45aa28d to
f63ce8d
Compare
gdanezis
approved these changes
Jan 10, 2022
| let ids_created = pop_arg!(args, u64); | ||
| let inputs_hash = pop_arg!(args, Vec<u8>); | ||
|
|
||
| // unwrap safe because digest length is checked in Move |
There was a problem hiding this comment.
Now that we do not have to keep rust and move in sync, we can address Issue #58 . We need to define a ObjectIDPreimage struct that holds (transaction_id, new_obj_sequence), then make it BcsSignable and use sha3_hash to get the digest. This ensures that we have one way to derive hashes (incl. for what we sign) and therefore domain separation is ensured uniformly.
Lets add a todo here, and add the above to issue #58 .
| // TODO(https://github.com/MystenLabs/fastnft/issues/58): | ||
| // audit ID derivation: do we want/need domain separation, different hash function, truncation ... | ||
|
|
||
| let mut hasher = Sha3_256::default(); |
There was a problem hiding this comment.
See my comment above on how to derive this in a uniform way in relation to all other hashes we derive.
huitseeker
approved these changes
Jan 10, 2022
| #[test_only] | ||
| /// Create a `Signer` from `bytes` for testing | ||
| public fun new_signer(bytes: vector<u8>): Signer { | ||
| Signer { inner: new(bytes) } |
There was a problem hiding this comment.
Nit: I have a feeling a length check here would not go amiss.
Previously, there were two incompatible implementations of ObjectID derivation. This PR: - Eliminates the `ObjectID` derivation inside Move and replaces it with a native function that invokes the Rust `ObjectID` derivation. This ensures that Rust and Move agree on how ID's are generated, and should also be more efficient than the previous approach. - Introduces a harness for invoking Move unit tests and a unit tests for `TxContext` that shows the ID generation working as expected.
sblackshear
force-pushed
the
native_object_id
branch
from
f63ce8d to
e694f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there were two incompatible implementations of ObjectID derivation. This PR:
ObjectIDderivation inside Move and replaces it with a native function that invokes the RustObjectIDderivation. This ensures that Rust and Move agree on how ID's are generated, and should also be more efficient than the previous approach.TxContextthat shows the ID generation working as expected.