feat: Parse and expand authority public keys once and reuse #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxade
reviewed
Jan 4, 2022
huitseeker
reviewed
Jan 5, 2022
There was a problem hiding this comment.
This is OK-ish, but I would note that whatever we gain here in point decompression just for the committee is more complex than manipulating ed25519 PubKeys in the first place.
That later approach is the better change, I think. See #122 for a PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of parsing and re-expanding all authority keys for each certificate we check, we expand them once and re-use the expanded public keys for multiple batch certificate verification.
On my bench I observe a ~7%-10% improvement in throughput, mostly due to
handle_confimation_ordertsaking less time.