[rpc][bugfix] Remove the usage of get_past_object_read from get_coin_metadata #11971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
666lcz
changed the title
wlmyng
approved these changes
May 12, 2023
666lcz
added a commit
that referenced
this pull request
May 15, 2023
…metadata (#11971) ## Description The current implementation of `get_coin_metadata` relies on `get_past_object_read`, which stops working if the fullnode has pruning enabled. This is unnecessary because we only need the latest version of the coinmetada object(if it is wrapped, then it's okay to return null). ## Test Plan tested locally ``` curl --location 'https://mainnet.sui.rpcpool.com' \ --header 'Content-Type: application/json' \ --data '{ "jsonrpc":"2.0", "id":1, "method":"suix_getCoinMetadata", "params":["0x2::sui::SUI"] }' ``` ``` { "jsonrpc": "2.0", "result": { "decimals": 9, "name": "Sui", "symbol": "SUI", "description": "", "iconUrl": null, "id": "0x9258181f5ceac8dbffb7030890243caed69a9599d2886d957a9cb7656af3bdb3" }, "id": 1 } ``` --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Fixed a bug for `get_coin_metadata` which can return null when the fullnode is pruned
12 tasks
666lcz
added a commit
that referenced
this pull request
May 15, 2023
…rom get_coin_… (#11999) …metadata (#11971) ## Description The current implementation of `get_coin_metadata` relies on `get_past_object_read`, which stops working if the fullnode has pruning enabled. This is unnecessary because we only need the latest version of the coinmetada object(if it is wrapped, then it's okay to return null). ## Test Plan tested locally ``` curl --location 'https://mainnet.sui.rpcpool.com' \ --header 'Content-Type: application/json' \ --data '{ "jsonrpc":"2.0", "id":1, "method":"suix_getCoinMetadata", "params":["0x2::sui::SUI"] }' ``` ``` { "jsonrpc": "2.0", "result": { "decimals": 9, "name": "Sui", "symbol": "SUI", "description": "", "iconUrl": null, "id": "0x9258181f5ceac8dbffb7030890243caed69a9599d2886d957a9cb7656af3bdb3" }, "id": 1 } ``` --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Fixed a bug for `get_coin_metadata` which can return null when the fullnode is pruned ## Description Describe the changes or additions included in this PR. ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
ronny-mysten
pushed a commit
that referenced
this pull request
May 17, 2023
…metadata (#11971) The current implementation of `get_coin_metadata` relies on `get_past_object_read`, which stops working if the fullnode has pruning enabled. This is unnecessary because we only need the latest version of the coinmetada object(if it is wrapped, then it's okay to return null). tested locally ``` curl --location 'https://mainnet.sui.rpcpool.com' \ --header 'Content-Type: application/json' \ --data '{ "jsonrpc":"2.0", "id":1, "method":"suix_getCoinMetadata", "params":["0x2::sui::SUI"] }' ``` ``` { "jsonrpc": "2.0", "result": { "decimals": 9, "name": "Sui", "symbol": "SUI", "description": "", "iconUrl": null, "id": "0x9258181f5ceac8dbffb7030890243caed69a9599d2886d957a9cb7656af3bdb3" }, "id": 1 } ``` --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration Fixed a bug for `get_coin_metadata` which can return null when the fullnode is pruned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
get_coin_metadatarelies onget_past_object_read, which stops working if the fullnode has pruning enabled. This is unnecessary because we only need the latest version of the coinmetada object(if it is wrapped, then it's okay to return null).Test Plan
tested locally
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Fixed a bug for
get_coin_metadatawhich can return null when the fullnode is pruned