3/n improve sui-json-rpc error codes and handling #11928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
wlmyng
force-pushed
the
better-error-handling-2
branch
from
a08d409 to
8d6bb51
Compare
wlmyng
force-pushed
the
better-error-handling-3
branch
from
a2b85e3 to
78474a6
Compare
wlmyng
force-pushed
the
better-error-handling-3
branch
from
78474a6 to
9a5c43b
Compare
wlmyng
changed the title
wlmyng
force-pushed
the
better-error-handling-3
branch
3 times, most recently
from
e43e266 to
2d14b52
Compare
wlmyng
force-pushed
the
better-error-handling-3
branch
2 times, most recently
from
3a68c7a to
fc79272
Compare
healthydeve
reviewed
May 16, 2023
healthydeve
reviewed
May 16, 2023
healthydeve
reviewed
May 16, 2023
healthydeve
approved these changes
May 16, 2023
wlmyng
force-pushed
the
better-error-handling-3
branch
from
3cb2856 to
4c5bb5d
Compare
wlmyng
force-pushed
the
better-error-handling-3
branch
from
ce4985b to
b305dcb
Compare
wlmyng
force-pushed
the
better-error-handling-3
branch
from
b305dcb to
ac46169
Compare
governance api coin api purge anyhow from transaction_execution_api
wlmyng
force-pushed
the
better-error-handling-3
branch
from
85d0068 to
029bb40
Compare
ronny-mysten
pushed a commit
that referenced
this pull request
May 17, 2023
## Description Replace anyhow errors with Error enum on sui-json-rpc where possible ## Test Plan How did you test the new or updated feature? --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes [API behavioral changes] - rpc methods that result in errors of variant `UserInputError`, `SuiRpcInputError`, `SuiError::TransactionNotFound` or `SuiError::TransactionsNotFound` now return error code `-32602` instead of `-32000`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace anyhow errors with Error enum on sui-json-rpc where possible
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
[API behavioral changes] - rpc methods that result in errors of variant
UserInputError,SuiRpcInputError,SuiError::TransactionNotFoundorSuiError::TransactionsNotFoundnow return error code-32602instead of-32000.