2/n improve sui-json-rpc error codes and handling

[wlmyng]

Description

Update authority.rs to use SuiResult instead of anyhow::Error. Some places that depended on anyhow::Error needed to be updated. Most noticeably, previously, because of anyhow::Error, there's no need to convert the underlying SuiError into Error (SuiJsonRpcError) where Rust can then do the conversion into Error (RpcError), as RpcError supports from anyhow::Error. Now though, we need to explicitly convert into the intermediary, causing instances where we have .map_err(Error::from)?.map_err(Error::from)?. One thought is to have an _internal() fn for all methods that rely on calls to state and other services.

Test Plan

Existing unit + integration tests. Manually call each api endpoint and verify that success and error responses are as expected

---

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

• user-visible impact
• breaking change for a client SDKs
• breaking change for FNs (FN binary must upgrade)
• breaking change for validators or node operators (must upgrade binaries)
• breaking change for on-chain data layout
• necessitate either a data wipe or data migration

Release notes

The following endpoints have a change in error response codes:

1. query_transaction_blocks
2. query_events
3. get_checkpoints
4. get_total_transaction_blocks
5. dev_inspect_transaction_block

Previously, these endpoints returned an error code of -32000 for any error response. With this update, if the underlying error maps to one of the following error types:

• UserInputError
• SuiError::TransactionNotFound
• SuiError::TransactionsNotFound

The error code will now be -32602 instead.

Action Required:

Clients and consumers of the API relying on the previous error code -32000 for handling specific errors should update their implementations to handle the new error code -32602. This will ensure the correct handling of errors related to UserInputError, TransactionNotFound, and TransactionsNotFound.

Also note that the error string for error variants not mentioned may be slightly different.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
explorer	⬜️ Ignored (Inspect)			May 12, 2023 2:26am
explorer-storybook	⬜️ Ignored (Inspect)			May 12, 2023 2:26am
sui-wallet-kit	⬜️ Ignored (Inspect)			May 12, 2023 2:26am
wallet-adapter	⬜️ Ignored (Inspect)			May 12, 2023 2:26am