Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a release build break #102

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Fix a release build break #102

merged 1 commit into from
Dec 29, 2021

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Dec 29, 2021

Building in release mode complains about num_immutable_objects not found.
Unfortunately macros in Rust works at runtime instead of compile time. So all variables in the macro are still compiled. They cannot be mixed with attributes which are compile time controls.

Copy link
Collaborator

@sblackshear sblackshear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@lxfind lxfind merged commit 6c1b40a into MystenLabs:main Dec 29, 2021
mwtian pushed a commit that referenced this pull request Sep 12, 2022
Support client subscribers
mwtian pushed a commit to mwtian/sui that referenced this pull request Sep 29, 2022
Support client subscribers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants