Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastx client] Client needs to track the latest ObjectDigest for objects, and provide them in orders #123

Closed
gdanezis opened this issue Jan 5, 2022 · 2 comments
Closed

[fastx client] Client needs to track the latest ObjectDigest for objects, and provide them in orders #123

gdanezis opened this issue Jan 5, 2022 · 2 comments
Assignees
@patrickkuo

Comments

@gdanezis
Copy link
Collaborator

gdanezis commented Jan 5, 2022

Currently the client does not track the ObjectDigest of objects it operates on, and as a result does not know what to provide when a full ObjectRef is required in an order. To mitigate this we have hacked the authority handlers to ignore the ObjectDigest in the ObjectRef in the orders, and instead to recompute the ObjectDigest from the objects retrieved locally.

We need to fix this hack:

  • The client needs to track the ObjectDigest of objects of interest.
  • The authority handlers and info response should return the full ObjectRef of objects including ObjectDigest back to clients.
  • The test and bench marking code for the client / authority needs to be fixed to include real ObjectDigests.
@gdanezis gdanezis mentioned this issue Jan 5, 2022
Merged
@patrickkuo
Copy link
Contributor

I will work on this if that's ok?

@lxfind lxfind added this to the Milestone 3 milestone Jan 21, 2022
@patrickkuo patrickkuo mentioned this issue Jan 21, 2022
Closed
@patrickkuo
Copy link
Contributor

this is done in #217

mwtian pushed a commit that referenced this issue Sep 12, 2022
@akichidis
fix: block_remover test failures on DB creation (#123)
cace50e 
fix: This commit is introducing the usage of the tempfile crate for the test docs of the block_waiter & block_remover to fix a race condition on temp files.
mwtian pushed a commit to mwtian/sui that referenced this issue Sep 29, 2022
@akichidis
fix: block_remover test failures on DB creation (MystenLabs#123)
e58f1fe 
fix: This commit is introducing the usage of the tempfile crate for the test docs of the block_waiter & block_remover to fix a race condition on temp files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickkuo patrickkuo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lxfind @patrickkuo @gdanezis