New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transaction Builder #41

Merged

bmwill merged 32 commits into master from tx_builder

Dec 5, 2024

Collaborator

stefan-mysten commented Oct 22, 2024

This is the first iteration on the transaction builder. I expect that it is not 100% correct as there are some areas that I am not sure about, thus I decided to push a PR to get some feedback.

Might be easier to go over it in a call, so we can also do that.

stefan-mysten requested a review from bmwill as a code owner

October 22, 2024 21:13

stefan-mysten requested a review from amnn

October 22, 2024 21:13

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

amnn reviewed

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

crates/sui-transaction-builder/src/lib.rs Show resolved Hide resolved

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

crates/sui-transaction-builder/src/lib.rs Show resolved Hide resolved

crates/sui-transaction-builder/src/object.rs Outdated Show resolved Hide resolved

crates/sui-transaction-builder/src/object.rs Outdated Show resolved Hide resolved

crates/sui-transaction-builder/src/object.rs Outdated Show resolved Hide resolved

crates/sui-transaction-builder/src/object.rs Outdated Show resolved Hide resolved

crates/sui-transaction-builder/src/object.rs Outdated Show resolved Hide resolved

Collaborator Author

stefan-mysten commented Oct 24, 2024

Thanks so much for the review @amnn 🚀

stefan-mysten force-pushed the tx_builder branch 3 times, most recently from 28d7deb to 17d7187 Compare

October 24, 2024 23:27

stefan-mysten requested a review from amnn

October 25, 2024 00:59

stefan-mysten force-pushed the tx_builder branch from 6e59091 to 693ffbc Compare

October 29, 2024 16:52

stefan-mysten commented

View reviewed changes

crates/sui-sdk-types/src/types/address.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-sdk-types/src/types/transaction/mod.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/error.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/error.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/error.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/error.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

Collaborator Author

stefan-mysten commented Oct 30, 2024

Bring in the macros for identifier, function, objectId, typetag.

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten commented

View reviewed changes

crates/sui-transaction-builder/src/lib.rs Outdated Show resolved Hide resolved

stefan-mysten added 26 commits

December 5, 2024 08:45


          Comment

2f77b1c


          Fix fmt

4cc7644


          Add sui binary to github path in the CI

695dea4


          Try something else

dd4ea22


          Try something else

1fd5d7d


          Try something else

71f3f7a


          Cleanup

6780ab6


          Cleanup

1b18ed8


          Cleanup

a9f8b6d


          Rework errors

8675d85


          Rework Makefile

75121f6


          Generate client.yaml file on the fly until we get to use a sui binary…

cc3323d

… with --ignore-chain support in --dump-bytecode-as-bas64


          Address feedback on errors

1fca6bf


          Cleanup Cargo.toml

af366a9


          Address feedback and cleanup

a312f4e


          Address feedback and cleanup

3fab901


          Add .gitignore

e382a0a


          Remove makefile

e54f940


          Update main makefile

5a93a66


          Fix Makefile and tests filename, and update gitignore

d9361cd


          Fix clippy

8e3b016


          Propagate the right version for shared inputs

ca9a2bf


          Fix issues with API

6ee310c


          Try to fix makefile

b6c3db9


          Final fixes

131d131


          Final fixes

15409d3

stefan-mysten force-pushed the tx_builder branch from 2866d05 to 15409d3 Compare

December 5, 2024 16:45


          Cleanup

4ab0fe8

bmwill merged commit 85b9a86 into master

6 checks passed

bmwill deleted the tx_builder branch

December 5, 2024 19:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet