This repository has been archived by the owner on Oct 17, 2022. It is now read-only.
Revert 818 + increase the batch timeout #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
revert-818-maintenance
branch
from
cc9d430 to
e8a9725
Compare
arun-koshy
reviewed
Aug 29, 2022
arun-koshy
approved these changes
Aug 29, 2022
huitseeker
force-pushed
the
revert-818-maintenance
branch
from
e8a9725 to
a50c257
Compare
This mitigates #858, which shows that on Github, this timeout is nto large enough. We also suspect this may alleviate issues encountered in Sui, e.g. failures in the Sui reconfiguration end_to_end test.
huitseeker
force-pushed
the
revert-818-maintenance
branch
from
a50c257 to
2549521
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_full_node_sync_floodin Sui had its runtime multiplied by 7 on a simple update to the precise commit of Batch execution with single execution adapter #818.We have not managed to clear up the issue, and would therefore like to revert #818, allowing more time to consider it for a later inclusion.
Besides this, we have noticed that the introduction of the block waiter in the executor (#738) has created issues (#858) in the speed of recovery when a batch transmission hits the batch request timeout. This bumps that batch request timeout, mitigating MystenLabs/sui#5212 as well as Sui issues suspected to be linked to this.
The hope is that this PR will allow closing MystenLabs/sui#4219, and rebasing MystenLabs/sui#4316 (which aims to update the NW pointer in Sui past the merge of #670) on the merge commit of the present PR.
/cc @aakoshh