-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates #23
Updates #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is nearly ready, but a little cleanup and getting it to run successfully need to be done first.
@@ -3,7 +3,7 @@ | |||
import os | |||
import requests | |||
import shutil | |||
from subprocess import check_call, CalledProcessError | |||
from subprocess import check_call, CalledProcessError, STDOUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allow reporting issues from the extract process to STDOUT for debugging.
|
||
from ep_testing.config import TestConfiguration, OS | ||
from ep_testing.tests.api import TestPythonAPIAccess, TestCAPIAccess, TestCppAPIDelayedAccess | ||
from ep_testing.tests.energyplus import TestPlainDDRunEPlusFile | ||
from ep_testing.tests.expand_objects import TestExpandObjectsAndRun | ||
from ep_testing.tests.hvacdiagram import HVACDiagram |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import the new HVACDiagram tester
@@ -32,6 +29,9 @@ def run(self): | |||
TransitionOldFile().run( | |||
self.install_path, self.verbose, {'last_version': self.config.tag_last_version} | |||
) | |||
HVACDiagram().run( | |||
self.install_path, self.verbose, {} | |||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run the new HVACDiagram tester.
@@ -75,7 +75,8 @@ def run(self, install_root: str, verbose: bool, kwargs: dict): | |||
my_env = os.environ.copy() | |||
if self.os == OS.Windows: # my local comp didn't have cmake in path except in interact shells | |||
my_env["PATH"] = install_root + ";" + my_env["PATH"] | |||
my_check_call(self.verbose, [py, python_file_path], env=my_env) | |||
idf_to_run = os.path.join(install_root, 'ExampleFiles', 'PythonPluginCustomOutputVariable.idf') | |||
my_check_call(self.verbose, [py, python_file_path, '-D', idf_to_run], env=my_env) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modify the API to run a PythonPlugin file to test that combination out.
@@ -8,3 +8,6 @@ | |||
for t in [5.0, 15.0, 25.0]: | |||
cp = glycol.specific_heat(state, t) | |||
rho = glycol.density(state, t) | |||
state2 = api.state_manager.new_state() | |||
api.runtime.set_console_output_status(state2, False) | |||
sys.exit(api.runtime.run_energyplus(state2, sys.argv[1:])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add running EnergyPlus (silently) to exercise some more of the API.
class BaseTest: | ||
|
||
def __init__(self): | ||
self.verbose = False | ||
temp_dir = mkdtemp() | ||
print('{Sandbox Dir: \"' + temp_dir + '\"} ', end='') | ||
chdir(temp_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have the base test create a sandbox directory...I think I need to clean this prior to merge.
Add mac12-arm64 to config.py and update documentation in setup.py
…udio version accordingly
Fixes #17 and fixes #19.