Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ProportionalDelegate and simplify code #64

Merged
merged 2 commits into from
Jan 16, 2019
Merged

Use ProportionalDelegate and simplify code #64

merged 2 commits into from
Jan 16, 2019

Conversation

notmart
Copy link
Contributor

@notmart notmart commented Jan 16, 2019

this does two main things:

  • introduces in Weather the usage of ProportionalDelegate to have a fully stretchable UI that maintains the same look and proportions on any window and screen size.
    This is not a silver bullet for every skill, but a good place to start for skills that are not much more than an icon and few text (and the design intent is to show the same result scaled on bigger screens rather than more content)
  • Also, componentizes more the weather skill: since every page needs the same JS function to resolve the weather lottie file, put it in a base WeatherDelegate used by all the other pages, also, since there are two identical forecast pages which only changes the days, make a component out of it as well, having forecast1 and forecast2 just instantiating it with a different model

(in general, files that should be used directly, should start with lowercase letter, and those to be reused as components must start with an uppercase letter)

@penrods penrods merged commit 3869b0c into MycroftAI:feature/mark2 Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants