Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Remove incorrectly added args in GUIWebsocketHandler methods #3036

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Remove incorrectly added args in GUIWebsocketHandler methods #3036

merged 3 commits into from
Nov 22, 2021

Commits on Nov 18, 2021

  1. Add default value for unused argument. 

    Direct calls to on_close do not need to pass an argument as it is
not used. Handlers however will pass a Message. Providing a None
default value allows for both mechanisms to co-exist.
    @krisgesling
    krisgesling committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    e343206 View commit details
    Browse the repository at this point in the history

  2. Add default values to on_message 

    If no message is passed, log it and do nothing.
    @krisgesling
    krisgesling committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    39a4725 View commit details
    Browse the repository at this point in the history

  3. Remove incorrectly added arguments 

    PR #2879 updated the websocket-client and changed function
signatures to account for API changes in that package. These
were falsely changed as the GUI bus does not use the
websocket-client.

Consistency would be good however modifying the protocols
would require significant work. For now we have two slightly
different bus interfaces.
    @krisgesling
    krisgesling committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    783576c View commit details
    Browse the repository at this point in the history