This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Make TTSCache safer #2914
Merged
Make TTSCache safer #2914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Failed (Results). |
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
reviewed
Jun 9, 2021
krisgesling
added
the
Type: Bug - quick
|
One can always create more tests :) I'll try to add some |
|
A couple of tests has been added! |
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
reviewed
Jun 10, 2021
Add __contains__ method to TTSCache, The cache contains a SHA if the SHA is known and all expected files exists on disk. This is handles unexpected system events in a more consistent manner and will still be fast for the case where a new sentence needs to be synthetisized.
forslund
force-pushed
the
feature/safer-tts-cache
branch
from
49485b6 to
4799caa
Compare
|
Thanks for noticing that mistake, Added the "gobo" check and corrected the logic snafu |
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
approved these changes
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
__contains__method to TTSCache, The cache contains a SHA if the SHA isknown and all expected files exists on disk.
This is handles unexpected system events in a more consistent manner and
will still be fast for the case where a new sentence needs to be
synthesized.
How to test
/tmp/mycroft/cache/Mimic2/(or the TTS you're using)Contributor license agreement signed?
CLA [ yes ]