This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
ReadTheDocs documentation: Fetch Mycroft-core version from mycroft.version #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the info block provided by the release script
forslund
added
the
Type: Refactoring and other improvements
devops-mycroft
added
the
CLA: Yes
forslund
changed the title
|
Voight Kampff Integration Test Succeeded (Results) |
|
Very nice - I have noticed this many times before! Is there a reason not to use the dict returned by |
|
I thought it better to not actually imort mycroft from the documentation configuration. |
krisgesling
added
the
Merge after next release
krisgesling
approved these changes
May 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the info block provided by the release script. Previously this was set to 0.1.0 and never changed, now it will follow the version info in Mycroft-Core using the simple script helper tags.
How to test
run
make htmlin the doc folder and ensure that the version in the generated docs (top left on all pages) matches the mycroft-core version.Contributor license agreement signed?
CLA [ Yes ]