-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Replace hardcoded use of /tmp directory #2892
Conversation
Hello @krisgesling! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-07 06:04:55 UTC |
015b302
to
0fb90ed
Compare
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
Voight Kampff Integration Test Succeeded (Results) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a single nit-picky comment, generally it looks good. Looking forward to getting this into core!
Voight Kampff Integration Test Failed (Results). |
Voight Kampff Integration Test Failed (Results). |
Voight Kampff Integration Test Failed (Results). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super nice now!
Voight Kampff Integration Test Failed (Results). |
Description
This adds a new method
get_temp_path()
that should be used anytime a temporary file or directory is needed. This replaces all uses of the hard coded/tmp
directory, in favor of the cross-systemtempfile.gettempdir()
The new method does not create any directories or files as it has no concept of whether the requested path contains a file or not.
Fixes #2727
Replaces #2740
All credit to @dzekem who identified the issue and did the bulk of the work on this.
How to test
Unit tests included.
This also touches many parts of the code base.
Contributor license agreement signed?