This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Remove intent-service backwards compatibilities #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
the
Type: Refactoring and other improvements
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
- Remove unused ContextManager import from mycroft.skills.intent_service - Remove Old 'intent_failure' -> fallback handler - Remove handling of fallback messages without the fallback_range parameter
forslund
force-pushed
the
refactor/clean-intent-service
branch
from
aa62634
to
203e1fc
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the now unused and deprecated imports and message handling code left to keep compatibility when the intent_service.py was refactored.
How to test
Make sure the intents work properly still.
Contributor license agreement signed?
CLA [ yes ] (Whether you have signed a CLA - Contributor Licensing Agreement