This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Don't run default update if autoupdate is disabled #2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Failed (Results) |
|
I tested this in combination with the Alpine Linux packaging and it works. Without this MR, the skills will never load with 20.2.5 as it tries to update them but doesn't have permission to do so. |
|
Voight Kampff Integration Test Succeeded (Results) |
|
Looks good, works as described. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The default skills check bypassed the autoupdate flag. This makes it respect it.
How to test
Disable skill autoupdate and remove a default skill, ensure that it's not installed at startup.
Contributor license agreement signed?
CLA [ Yes ]