Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

remove previously deprecated error message #2669

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

krisgesling
Copy link
Contributor

Description

Remove the previously deprecated skills.converse.error message that was emitted alongside skills.converse.response for compatibility. Has been marked for removal and I can't find anything still using it.

Contributor license agreement signed?

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Aug 18, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, still works as expected. (this was a very theoretical thing to keep around in the first place)

@krisgesling krisgesling merged commit 1b64285 into dev Aug 21, 2020
@krisgesling krisgesling deleted the remove/converse-error branch September 2, 2020 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants