This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Fix settings changed check after skill handler #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
Make self._initial_settings have an unique copy of the settings and not a reference to the original ones.
forslund
force-pushed
the
bugfix/save-settings
branch
from
05bc46a to
6abfca6
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
|
Looks good, and fixes the issue in Reminders. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue was reported by @emphasize here MycroftAI/skill-reminder#37. Mycroft doesn't detect changes because after the initial change the
_initial_settingsreference is refering to the same memory as thesettingsmember. This was earlier fixed for the initial setup of_initial_settingsbut the check at the end of intent handler was overlooked.How to test
Use the reminder skill to set a couple of reminders, make sure they're all stored in the settings.json and not just the first.
Contributor license agreement signed?
CLA [ Yes ]