Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

revert iot dig_for_message #2636

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

jamesmf
Copy link
Contributor

@jamesmf jamesmf commented Jul 15, 2020

Description

fixes #2635
#2635

Reverts the code that assumes that the CommonIoTSkill asks for other skills to register instead of individual skills calling register_words of their own accord.

Discussion with author of the change being reverted ( @JarbasAI ) here:
https://chat.mycroft.ai/community/pl/w66y18fgj7ygt8u3j6pdsxsofc

How to test

Try to install a skill that extends CommonIotSkill like the HomeAssistant branch

Contributor license agreement signed?

CLA [X ] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft
Copy link

Hello, @jamesmf, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Jul 15, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Jul 15, 2020
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, this change looks good.

@krisgesling krisgesling merged commit fc31079 into MycroftAI:dev Jul 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommonIoTSkill subclasses can't initialize with register_entities_and_scenes
4 participants