Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

remove messagebus argument #2625

Merged
merged 1 commit into from
Jun 29, 2020
Merged

remove messagebus argument #2625

merged 1 commit into from
Jun 29, 2020

Conversation

krisgesling
Copy link
Contributor

Description

The unused messagebus reference got removed from the function signature, but not from the call of that function or docstring.

This removes that reference, preventing the timeout from receiving a reference to the messagebus instead on an int.

How to test

Start some music and then trigger the wake word.

Contributor license agreement signed?

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Jun 29, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for missing this earlier. The change looks good.

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling
Copy link
Contributor Author

Nope was my bad :)

@krisgesling krisgesling merged commit 072f409 into dev Jun 29, 2020
@krisgesling krisgesling deleted the bugfix/audio-after-stop branch September 2, 2020 21:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Bug - complex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants