This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Fix audio service startup without Internet #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If started up without Network connection the audio service would crash importing the google_tts module as it tried to fetch language list from google. This restructures it to be a just-in-time check. It also adds a cached list of supported languages to use if an error occurs fetching language codes. A small fix allowing "en-US" to be matched to "en-us" instead of the generic "en" is also included.
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
|
Looks good and tested on Linux and Picroft. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If started up without Network connection the audio service would crash
importing the google_tts module as it tried to fetch language list from
google.
This restructures it to be a just-in-time check. It also adds a cached
list of supported languages to use if an error occurs fetching language
codes.
A small fix allowing "en-US" to be matched to "en-us" instead of the
generic "en" is also included.
How to test
Insert a
raise Exceptionat L74 and make sure that the audio service process can start.Contributor license agreement signed?
CLA [ Yes ]