Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Feature/email jenkins results #2530

Merged
merged 4 commits into from
Apr 10, 2020
Merged

Feature/email jenkins results #2530

merged 4 commits into from
Apr 10, 2020

Conversation

chrisveilleux
Copy link
Member

Description

Add steps to Jenkinsfile to email the results of integration tests on success or failure

How to test

  • Make a branch off of this one and create local version of it
  • add the branch name to the "when" clause in the integration test stage
  • push change to origin

Contributor license agreement signed?

CLA [yes]

@chrisveilleux chrisveilleux added type: feature CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) labels Apr 3, 2020
@chrisveilleux chrisveilleux requested a review from forslund April 3, 2020 21:20
@forslund
Copy link
Collaborator

forslund commented Apr 6, 2020

Should we send success-emails? I'd say it's better to only send things when there is something worth noting.

@krisgesling
Copy link
Contributor

I'm guessing this will be a personal preference thing.

For me, I prefer to get something either way. If I don't get any email I don't know if the job succeeded or the system just failed to email me.

@forslund
Copy link
Collaborator

forslund commented Apr 6, 2020

Well Github shows the jobs that have finished and their status so I think that information is available and only really of interest to the one reviewing a PR. since a contributor won't have the possibility to access the Jenkins job and restart it afaik.

@krisgesling
Copy link
Contributor

I assumed the allure report would be accessible to anyone with the link so they can't restart the job but they could see why their build failed.

@forslund
Copy link
Collaborator

forslund commented Apr 6, 2020

Yeah exactly, for a failure that's useful but for a success it's redundant imho.

@forslund
Copy link
Collaborator

forslund commented Apr 6, 2020

I realize now that the results can't be viewed at all except from the link in the e-mail. So maybe it's good to have for now. In the long term I do think we should try to get the report returned to the PR instead if the build is successful.

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a couple of minor issues. The big issue is that I don't seem to be getting the e-mail to my personal mail account despite Jenkins warning that the mail is sent to an unregistered address...

Jenkinsfile Outdated
</a>
</p>""",
replyTo: '[email protected]',
to: '[email protected]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also sends to devs instead of dev.

<a href='${BUILD_URL}'>
Jenkins Build Details
</a>
&nbsp(Requires account on Mycroft's Jenkins instance)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-breaking space doesn't render correctly in the e-mail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you be more specific? I noticed a space in the link after the text but not sure how to get rid of it.

Jenkinsfile Outdated Show resolved Hide resolved
@forslund forslund force-pushed the feature/email-jenkins-results branch from 7f95c0f to a24e1ea Compare April 10, 2020 15:59
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@forslund forslund merged commit b3fef7b into dev Apr 10, 2020
@forslund forslund deleted the feature/email-jenkins-results branch April 10, 2020 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants