-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
Should we send success-emails? I'd say it's better to only send things when there is something worth noting. |
I'm guessing this will be a personal preference thing. For me, I prefer to get something either way. If I don't get any email I don't know if the job succeeded or the system just failed to email me. |
Well Github shows the jobs that have finished and their status so I think that information is available and only really of interest to the one reviewing a PR. since a contributor won't have the possibility to access the Jenkins job and restart it afaik. |
I assumed the allure report would be accessible to anyone with the link so they can't restart the job but they could see why their build failed. |
Yeah exactly, for a failure that's useful but for a success it's redundant imho. |
I realize now that the results can't be viewed at all except from the link in the e-mail. So maybe it's good to have for now. In the long term I do think we should try to get the report returned to the PR instead if the build is successful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted a couple of minor issues. The big issue is that I don't seem to be getting the e-mail to my personal mail account despite Jenkins warning that the mail is sent to an unregistered address...
Jenkinsfile
Outdated
</a> | ||
</p>""", | ||
replyTo: '[email protected]', | ||
to: '[email protected]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also sends to devs instead of dev.
<a href='${BUILD_URL}'> | ||
Jenkins Build Details | ||
</a> | ||
 (Requires account on Mycroft's Jenkins instance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non-breaking space doesn't render correctly in the e-mail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you be more specific? I noticed a space in the link after the text but not sure how to get rid of it.
…irectory to differentiate from tests run on the skill repository.
7f95c0f
to
a24e1ea
Compare
Voight Kampff Integration Test Succeeded (Results) |
Description
Add steps to Jenkinsfile to email the results of integration tests on success or failure
How to test
Contributor license agreement signed?
CLA [yes]