Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 19 fix, add ip as a parameter #22

Merged
merged 1 commit into from
Oct 10, 2018
Merged

issue 19 fix, add ip as a parameter #22

merged 1 commit into from
Oct 10, 2018

Conversation

el-tocino
Copy link

the else wasn't returning as a byte stream which is what issue 19 was about.

Also adjusted the parameters to include IP address as an option. use --ip 127.0.0.1 (or whatever) to specify an ip, if not included will default to listening on all ip's.

Copy link

@LearnedVector LearnedVector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks :)

@LearnedVector LearnedVector merged commit 00b92b5 into MycroftAI:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants