-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract_datetime_en() fails silently on "<of this/next/last> <year/month/week>", returns wrong datetime #59
Comments
Thanks to this forum post by user tiredoftry for discovering this via asking about the weather |
i think the problem might be somewhere in the nice_date utils, doesn't sound like it is in extract_datetime because "yesterday" wasn't handled at all fix for extracting "yesterday" and "X days ago" available in lingua_franca |
i'm able to extract the "X days ago" part but i'm facing issues while dealing with "X days later" |
Suggest migrating this to Lingua Franca and editing to reflect the parts Jarbas has fixed, unless "yesterday" is regarded as critical enough to warrant porting that fix back here. |
Good call. Yesterday we started pushing for getting lingua-franca used directly by core so it's definitely better to continue the work there. |
#96 closes this |
* partial fix/mycroft#39 - handle last/past year/month/week * support for X day/week/month/year ago support for weekends * support for X day/week/month/year ago * leave "this X" for a follow up PR * next second/minute/hour * within the XX * more tests - better disambiguation * more tests - X time later * add tests for known failing cases "with the X" * - fix offsets, use relativedelta - handle X {time unit} earlier - handle fractional decades/centuries/millenium - handle decades/centuries/millenium ago - add failing tests for extract last N {timeunit} * fix "in the last N {timeunit}" Co-authored-by: jarbasai <[email protected]>
https://github.com/MycroftAI/mycroft-core/blob/a3e35d736b0426f33b7fc1d1883be38e4b650b0b/mycroft/util/lang/parse_en.py#L667
Several cases not yet implemented and consequently parsing incorrectly:
The text was updated successfully, but these errors were encountered: