Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/53 #148

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Issues/53 #148

merged 2 commits into from
Sep 16, 2021

Conversation

clusterfudge
Copy link
Collaborator

  • Description of what the PR does, such as fixes # {issue number}
    Fixes error in TrieNode.is_prefix #53

  • Description of how to validate or test this PR
    New tests added to test/TrieTest.py.

./run_tests.sh

  • Whether you have signed a CLA (Contributor Licensing Agreement)
    yes

Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! (Nice to see that Kermit lives on in the test cases :) )

@clusterfudge
Copy link
Collaborator Author

I forgot to bump the version here, but I'm not super concerned because of the upcoming major version bump and the fact that this is not intended to be a publicly facing API.

@clusterfudge clusterfudge merged commit a9e0df0 into master Sep 16, 2021
@forslund forslund deleted the issues/53 branch September 16, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in TrieNode.is_prefix
2 participants